Disable rust when sanitizers are active#20
Open
emmatyping wants to merge 2 commits into3.15-rust-in-cpythonfrom
Open
Disable rust when sanitizers are active#20emmatyping wants to merge 2 commits into3.15-rust-in-cpythonfrom
emmatyping wants to merge 2 commits into3.15-rust-in-cpythonfrom
Conversation
In a follow up, we should enable sanitizers using nightly and the unstable sanitizers support, which works with all CPython sanitizers except undefined-behavior sanitizer. Unstable sanitizers support: https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html
|
ASAN should be ok with only some code compiled under it -- MSAN requires everything to be compiled with it though. I don't know the other sanitizers by hand. |
Author
|
@alex Interesting! Looking through the clang docs, it looks like only msan requires the entire binary to be instrumented (which makes sense). It looks like tsan and ubsan both cause issues with the bindings generation, so I'll allow Rust to build with asan, we can work on enabling the others in a follow up. |
Author
|
Example of failed tsan run: https://github.com/Rust-for-CPython/cpython/actions/runs/20551830853/job/59030589093?pr=17 Example of failed ubsan run: https://github.com/Rust-for-CPython/cpython/actions/runs/20551830853/job/59030589072?pr=17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a follow up, we should enable sanitizers using nightly and the unstable sanitizers support, which works with all CPython sanitizers except undefined-behavior sanitizer.
Unstable sanitizers support: https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html